diff --git a/tests/framework/layer/test_layer.cpp b/tests/framework/layer/test_layer.cpp index c2747c8b6..2764f665c 100644 --- a/tests/framework/layer/test_layer.cpp +++ b/tests/framework/layer/test_layer.cpp @@ -654,11 +654,11 @@ VKAPI_ATTR void VKAPI_CALL test_vkDestroyDevice(VkDevice device, const VkAllocat layer.second_device_created_during_create_device.dispatch_table.DestroyDevice); } - for (auto& created_device : layer.created_devices) { - if (created_device.device_handle == device) { - created_device.dispatch_table.DestroyDevice(device, pAllocator); - break; - } + auto it = std::find_if(std::begin(layer.created_devices), std::end(layer.created_devices), + [device](const TestLayer::Device& dev) { return device == dev.device_handle; }); + if (it != std::end(layer.created_devices)) { + it->dispatch_table.DestroyDevice(device, pAllocator); + layer.created_devices.erase(it); } } diff --git a/tests/loader_debug_ext_tests.cpp b/tests/loader_debug_ext_tests.cpp index e5472e49d..aa6b7f0e7 100644 --- a/tests/loader_debug_ext_tests.cpp +++ b/tests/loader_debug_ext_tests.cpp @@ -1074,11 +1074,11 @@ TEST(GetProcAddr, DebugFuncsWithTrampoline) { driver.physical_devices.at(0).add_extensions({"VK_KHR_swapchain"}); // Hardware doesn't support the debug extensions - // // Use getDeviceProcAddr & vary enabling the debug extensions + // Use getDeviceProcAddr & vary enabling the debug extensions ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, false, false)); ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, true, false)); - // // Use getInstanceProcAddr & vary enabling the debug extensions + // Use getInstanceProcAddr & vary enabling the debug extensions ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, true, false, false)); ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, true, true, false)); @@ -1108,11 +1108,11 @@ TEST(GetProcAddr, DebugFuncsWithDebugExtsForceAdded) { driver.physical_devices.at(0).add_extensions({"VK_KHR_swapchain"}); // Hardware doesn't support the debug extensions - // // Use getDeviceProcAddr & vary enabling the debug extensions + // Use getDeviceProcAddr & vary enabling the debug extensions ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, false, false)); ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, true, false)); - // // Use getInstanceProcAddr & vary enabling the debug extensions + // Use getInstanceProcAddr & vary enabling the debug extensions ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, true, false, false)); ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, true, true, false)); @@ -1126,7 +1126,7 @@ TEST(GetProcAddr, DebugFuncsWithDebugExtsForceAdded) { .add_injected_instance_extensions({{VK_EXT_DEBUG_REPORT_EXTENSION_NAME}, {VK_EXT_DEBUG_UTILS_EXTENSION_NAME}}) .add_injected_device_extension({VK_EXT_DEBUG_MARKER_EXTENSION_NAME}); - // // Use getDeviceProcAddr & vary enabling the debug extensions + // Use getDeviceProcAddr & vary enabling the debug extensions ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, false, true)); ASSERT_NO_FATAL_FAILURE(CheckDeviceFunctions(env, false, true, true));