Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to use 16 compute nodes in colocale performance testing #26781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-kayrakli
Copy link
Contributor

This PR passes --numLocales=32 to start_test to ensure that we get 16 compute nodes in colocale performance testing.

Note that colocale testing uses CHPL_RT_LOCALES_PER_NODE=2 to ask for colocales, which, with -nl16 results in using 8 compute nodes.

@e-kayrakli e-kayrakli requested a review from jhh67 February 25, 2025 22:06
@jhh67
Copy link
Contributor

jhh67 commented Feb 25, 2025

How does this interact with tests that have their own .numlocales file?

@e-kayrakli
Copy link
Contributor Author

How does this interact with tests that have their own .numlocales file?

Oh, that's a good question. I think .numlocales is for correctness and .ml.numlocales are for multilocale performance. There is also .cc.numlocales for comm counts.

Based on find test -name "*ml-numlocales" | xargs cat, I get a lot of 16s, some 8s and some 2s. I am not sure how to handle those. Some options:

  • let them be: maybe there is something sensitive to numLocales in those tests
  • change ml-numlocales to ml.numnodes and how it is interpreted by the nightly testing rig.
  • make either of these decisions based on tests, but there are quite a few tests.

@e-kayrakli
Copy link
Contributor Author

Another option: update all of these to have 16, 16x2 for both standard and colocale performance testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants