Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Gitlab repository pull_requests pr_closed_at column null when pr is merged #2924

Open
cdolfi opened this issue Oct 11, 2024 · 1 comment · Fixed by #2955
Open

BUG: Gitlab repository pull_requests pr_closed_at column null when pr is merged #2924

cdolfi opened this issue Oct 11, 2024 · 1 comment · Fixed by #2955
Assignees
@ABrain7710
Labels
feature-request Request for a new feature in Augur

Comments

@cdolfi
Copy link

cdolfi commented Oct 11, 2024

image
@cdolfi cdolfi added the bug Documents unexpected/wrong/buggy behavior label Oct 11, 2024
@cdolfi cdolfi added this to Augur TSC Oct 11, 2024
@sgoggins
Copy link
Member

@cdolfi : These actually look right. A PR/MR can be closed (without merging) or Merged. HOWEVER, you're right that we are doing the closed_at as the merged_at on GitHub ... So, we'll fix that! :)

@sgoggins sgoggins added feature-request Request for a new feature in Augur and removed bug Documents unexpected/wrong/buggy behavior labels Oct 15, 2024
@sgoggins sgoggins linked a pull request Dec 5, 2024 that will close this issue
set closed at as merged at when closed at is missing #2955
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABrain7710 ABrain7710

Labels
feature-request Request for a new feature in Augur
Projects
Augur TSC
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set closed at as merged at when closed at is missing chaoss/augur
3 participants
@sgoggins @cdolfi @ABrain7710