feat: spatial refactor #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 76.57% 76.58%
=======================================
Files 88 88
Lines 6994 7020 +26
=======================================
+ Hits 5356 5376 +20
- Misses 1638 1644 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tihuan
reviewed
Apr 1, 2024
| @@ -15,6 +15,7 @@ | |||
| "e2e-dev": "CXG_URL_BASE=https://cellxgene.dev.single-cell.czi.technology playwright test", | |||
| "e2e-stage": "CXG_URL_BASE=https://cellxgene.staging.single-cell.czi.technology playwright test", | |||
| "e2e-prod": "CXG_URL_BASE=https://cellxgene.cziscience.com playwright test", | |||
| "e2e-copy-snapshots-to-linux": "for file in __tests__/e2e/e2e.test.ts-snapshots/*-darwin.txt; do cp \"$file\" \"${file/-darwin.txt/-linux.txt}\"; done", | |||
There was a problem hiding this comment.
PSA: Use npm run e2e-copy-snapshots-to-linux to copy updated darwin snapshots to linux equivalents!
seve
approved these changes
Apr 1, 2024
|
e2e all passing now 🤩 👏 !! Thanks for the amazing work, everyone!! |
tihuan
reviewed
Apr 3, 2024
|
Don't worry about the UI Tests part! I rejected some snapshots because the current ones are better than the PR ones |
seve
reviewed
Apr 3, 2024
tihuan
reviewed
Apr 3, 2024
|
tagging @atarashansky if you could look and comment on the b/e implementation 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following:
uns/metasuper-cool-spatialTested for following scenarios -
All above tested with feature flag on and off along with image download
Screen.Recording.2024-04-01.at.7.35.28.PM.mov