fix: add screenCap to cached props for diffing during render check #835
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 76.57% 76.57%
=======================================
Files 88 88
Lines 6994 6994
=======================================
Hits 5356 5356
Misses 1638 1638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| height, | ||
| width, | ||
| imageUnderlay, | ||
| screenCap, |
There was a problem hiding this comment.
just wanted to double check, screenCap was coming from this.props, but now we're getting it from asyncProps. Is that intentional? Thanks!
There was a problem hiding this comment.
it's not necessary to get it from asyncProps here, both places are correct. The reason we're adding screenCap to watchProps is to piggyback on the prop caching.
There was a problem hiding this comment.
these files can all be deleted?
There was a problem hiding this comment.
Ah nvm, this is the new spatial dataset. Thanks for adding this, Seve!
|
@seve can you help putting down a description of the bug, so the reviewers have more context please? Thank you! |
|
@seve PTAL this approach! Would love to see what you think 🙏 Thank you! |
Co-authored-by: Timmy Huang <[email protected]>
Added some checks to see if screenCap differs from last attempt to re-render before actually triggering re-render.
Also adds new spatial dataset to example-datasets
These changes prevent the image download flow from download multiple images when pressed a single time while the spatial feature flag is enabled
#823