Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 70 add portal collection homepage to /config #83

Merged
merged 5 commits into from
Sep 30, 2021
Merged

feat: 70 add portal collection homepage to /config #83

merged 5 commits into from
Sep 30, 2021

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Sep 23, 2021 •
edited
Loading

Reviewers

Functional:
@MDunitz @MillenniumFalconMechanic

Readability:
@seve

Ticket #70

Changes

  • Adds the portal home page to the /config endpoint

@ebezzi ebezzi requested a review from MDunitz September 23, 2021 15:51
ebezzi
ebezzi commented Sep 23, 2021
View reviewed changes
server/tests/unit/common/test_api.py
@@ -843,6 +841,43 @@ def test_dataset_metadata_api_fails_gracefully_on_connection_failure(self, mock_

self.assertEqual(result.status_code, HTTPStatus.BAD_REQUEST)

class TestConfigEndpoint(BaseTest):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the tests in the other suites aren't independent, so adding this to an existing suite doesn't work (it causes other tests to fail). Rewriting this file to have independent tests would be great.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the server config setup? or something else that prevents the test from being independent?

@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@ae60d1b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head eb99664 differs from pull request most recent head 42716d2. Consider uploading reports for the commit 42716d2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   71.82%           
=======================================
  Files           ?      126           
  Lines           ?    10086           
  Branches        ?        0           
=======================================
  Hits            ?     7244           
  Misses          ?     2842           
  Partials        ?        0
Flag Coverage Δ
frontend 71.82% <0.00%> (?)
javascript 71.82% <0.00%> (?)
smokeTest ∅ <0.00%> (?)
unitTest 71.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae60d1b...42716d2. Read the comment docs.

MDunitz
MDunitz approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebezzi ebezzi enabled auto-merge (squash) September 30, 2021 17:08
@ebezzi ebezzi merged commit 8e0dd91 into main Sep 30, 2021
@ebezzi ebezzi deleted the ebezzi/70-portal-collection-homepage-in-config branch September 30, 2021 17:14
@czi-github-helper czi-github-helper bot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDunitz MDunitz MDunitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebezzi @MDunitz @tihuan