Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regex API prefix substitution for dataset selection #807

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Mar 4, 2024

  • Fixes an issue with the new REGEX not properly updating the API prefix when selecting a new dataset
  • Fixes an issue with trailing slashes when trying to access a CXG on localhost:3000 (this broke local e2e tests).

The "REGEX_PATHNAME_FOR_DATASET_SELECTOR" is what the original regex was prior to the changes made for enabling access to CXGs in S3 subfolders

Tested in a pirated dev deployment since we do not have test infrastructure for testing dataset selection.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (b7d377b) to head (49779fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files          88       88           
  Lines        6802     6802           
=======================================
  Hits         5288     5288           
  Misses       1514     1514           
Flag Coverage Δ
frontend 77.74% <ø> (ø)
javascript 77.74% <ø> (ø)
smokeTest ∅ <ø> (∅)
unitTest 77.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atarashansky atarashansky changed the title (test): debug fix: fix regex API prefix substitution for dataset selection Mar 4, 2024
@atarashansky atarashansky requested a review from seve March 4, 2024 22:15
@atarashansky atarashansky marked this pull request as ready for review March 4, 2024 22:16
@atarashansky atarashansky requested a review from tihuan March 4, 2024 22:33
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding the comments to capture context for the code 🥇 Thanks so much, Alec 🙏 !!

@atarashansky atarashansky merged commit bd4f07a into main Mar 4, 2024
4 checks passed
@atarashansky atarashansky deleted the atar-debug-rdev branch March 4, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants