feat: add feature flags to explorer #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seve
commented
Feb 20, 2024
seve
commented
Feb 20, 2024
Comment on lines
-46
to
-50
| _onURLChanged(): void { | ||
| const { dispatch } = this.props; | ||
| dispatch({ type: "url changed", url: document.location.href }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This action doesn't exist
seve
commented
Feb 20, 2024
| @@ -329,6 +334,23 @@ class MenuBar extends React.PureComponent<{}, State> { | |||
| /> | |||
| </ButtonGroup> | |||
| ) : null} | |||
| {isSpatial && ( | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 88 88
Lines 6782 6782
=======================================
Hits 5270 5270
Misses 1512 1512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tihuan
approved these changes
Feb 21, 2024
Comment on lines
-46
to
-50
| _onURLChanged(): void { | ||
| const { dispatch } = this.props; | ||
| dispatch({ type: "url changed", url: document.location.href }); | ||
| } | ||
|
|
| @@ -206,6 +206,9 @@ function QuickGene() { | |||
| itemDisabled={userDefinedGenesLoading ? () => true : () => false} | |||
| noResults={<MenuItem disabled text="No matching genes." />} | |||
| onItemSelect={(g) => { | |||
| // (seve): I made an attempt at typing this, but it looks like the type of g is not consistent with the type of the argument in onItemSelect | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#741
This PR adds the ability to add and utilize feature flags in explorer.
Use
?spatial=truefor testing, you should see a new button on the menu bar with a train icon