Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add correlation ids to logs to improve debugging #606

Merged
merged 3 commits into from
May 12, 2023

Conversation

Bento007
Copy link
Contributor

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #606 (0ca6865) into main (8677fc9) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 0ca6865 differs from pull request most recent head 1bd399c. Consider uploading reports for the commit 1bd399c to get more accurate results

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   77.41%   77.61%   +0.20%     
==========================================
  Files          84       88       +4     
  Lines        6678     6738      +60     
==========================================
+ Hits         5170     5230      +60     
  Misses       1508     1508              
Flag Coverage Δ
frontend 77.61% <100.00%> (+0.20%) ⬆️
javascript 77.61% <100.00%> (+0.20%) ⬆️
unitTest 77.61% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/app/app.py 64.66% <100.00%> (+1.09%) ⬆️
server/app/logging.py 100.00% <100.00%> (ø)
server/app/request_id.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bento007 Bento007 requested a review from a team May 11, 2023 23:44
@Bento007 Bento007 enabled auto-merge (squash) May 12, 2023 16:16
@Bento007 Bento007 merged commit 2540fd9 into main May 12, 2023
@Bento007 Bento007 deleted the tsmith/request-id branch May 12, 2023 16:30
Bento007 added a commit that referenced this pull request May 16, 2023
* apply pre-commit (#590)
* feat: Add correlation ids to logs to improve debugging (#606)

- Add a unique request_id to all messages logged per request.
- Return a unique X-Request-ID that correlated with log messages produce during a request.
- Add JSON log formatter to format all logs into JSON.
Bento007 added a commit that referenced this pull request May 18, 2023
* apply pre-commit (#590)
* feat: Add correlation ids to logs to improve debugging (#606)

- Add a unique request_id to all messages logged per request.
- Return a unique X-Request-ID that correlated with log messages produce during a request.
- Add JSON log formatter to format all logs into JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add correlation ids to logs to improve debugging
2 participants