Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return response caching #199

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix: return response caching #199

merged 1 commit into from
Nov 30, 2021

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Nov 30, 2021

Reviewers

Functional:

Readability:


Changes

  • add check when s3_uri is None
  • add typing
  • add additional testing

- add check when s3_uri is None
- add typing
- add additional testing
@Bento007 Bento007 enabled auto-merge (squash) November 30, 2021 17:43
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #199 (608b12b) into main (fdda2f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   70.40%   70.41%   +0.01%     
==========================================
  Files         132      132              
  Lines       10022    10026       +4     
==========================================
+ Hits         7056     7060       +4     
  Misses       2966     2966              
Flag Coverage Δ
frontend 70.41% <100.00%> (+0.01%) ⬆️
javascript 70.41% <100.00%> (+0.01%) ⬆️
smokeTest ?
unitTest 70.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/app/api/util.py 100.00% <100.00%> (ø)
server/data_common/dataset_metadata.py 93.75% <100.00%> (+0.09%) ⬆️
app/api/util.py 100.00% <0.00%> (ø)
data_common/dataset_metadata.py 93.75% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdda2f4...608b12b. Read the comment docs.

Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM!

@Bento007 Bento007 merged commit 844c61f into main Nov 30, 2021
@Bento007 Bento007 deleted the tsmith/cache-fix-2 branch November 30, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants