fix: local console errors #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tihuan
commented
Jul 10, 2024
tihuan
commented
- Add explicit known local transient errors to ignore, so we can catch other unknown errors in local e2e tests
- Fix some components that cause errors in the console
tihuan
commented
Jul 10, 2024
Comment on lines
-23
to
-45
| interface Props { | ||
| interface StateProps { | ||
| isColorAccessor: boolean; | ||
| isScatterplotXXaccessor: boolean; | ||
| isScatterplotYYaccessor: boolean; | ||
| isGeneInfo: boolean; | ||
| } | ||
|
|
||
| interface DispatchProps { | ||
| dispatch: AppDispatch; | ||
| } | ||
|
|
||
| interface OwnProps { | ||
| gene: string; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any -- FIXME | ||
| quickGene: any; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any -- FIXME | ||
| removeGene: any; | ||
| quickGene?: boolean; | ||
| removeGene?: (gene: string) => () => void; | ||
| geneId: DataframeValue; | ||
| isGeneExpressionComplete: boolean; | ||
| onGeneExpressionComplete: () => void; | ||
| geneDescription?: string; | ||
| geneset?: string; | ||
| } | ||
|
|
||
| // @ts-expect-error ts-migrate(1238) FIXME: Unable to resolve signature of class decorator whe... Remove this comment to see the full error message | ||
| @connect((state: RootState, ownProps: Props) => { | ||
| const { gene } = ownProps; | ||
| type Props = StateProps & OwnProps & DispatchProps; | ||
|
|
||
| return { | ||
| isColorAccessor: | ||
| state.colors.colorAccessor === gene && | ||
| state.colors.colorMode !== "color by categorical metadata", | ||
| isScatterplotXXaccessor: state.controls.scatterplotXXaccessor === gene, | ||
| isScatterplotYYaccessor: state.controls.scatterplotYYaccessor === gene, | ||
| }; | ||
| }) |
| @@ -183,7 +174,7 @@ class Gene extends React.Component<Props, State> { | |||
| </Truncate> | |||
| </div> | |||
| <div style={{ display: "inline-block", marginLeft: "0" }}> | |||
| <Button | |||
| <AnchorButton | |||
There was a problem hiding this comment.
nested button is invalid HTML
| @@ -160,17 +161,15 @@ function QuickGene() { | |||
| } | |||
|
|
|||
| return ( | |||
| <> | |||
There was a problem hiding this comment.
this innocent fragment tag throws unique key error
tihuan
force-pushed
the
thuang-fix-local-console-errors
branch
from
108e497 to
7a1f4e0
Compare
kaloster
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.