chore: Add test for bug #1022 color by category #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tihuan
commented
Jul 8, 2024
tihuan
commented
- Add test to prevent regression for bug bug(P0): Explorer Page Goes Blank When Color By Filters Are Changed #1022
tihuan
force-pushed
the
thuang-add-test-for-fix-color-by-category
branch
from
2270151 to
26e18b2
Compare
tihuan
changed the title
tihuan
commented
Jul 8, 2024
| @@ -485,7 +490,7 @@ const CategoryHeader = React.memo( | |||
| hide: { enabled: false }, | |||
| }} | |||
| > | |||
| <AnchorButton | |||
| <Button | |||
There was a problem hiding this comment.
clean up - anchor button is an <a> that look like a button, but not a <button> tag. In this case, we want <button>
kaloster
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.