-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Graph meta tags to each page #900
Comments
@codemonkey800 split ticket into different tickets for: metadata vs. image service TBD on image service effort; @codemonkey800 to follow up w/ @neuromusic |
almost done with a PR for this, but currently running into an issue with duplicate meta tags being stuck on the page after initial render: meta-tags-duplicate-issue.mp4I'm looking into a fix right now |
actually I looked into it more, and I think it's fine if we hold off on fixing the above issue for now. what's important is the meta tags are correct on initial render, and they are: it seems like the duplicates happen after Next.js hydrates the page, but for open graph it doesn't matter since it doesn't use JavaScript to load the tags |
created a separate issue to track the above bug: |
Open Graph meta tags allow us to enrich the appearance of links on social media. We currently have Open Graph tags implemented for collections: #553
But we do not have it for other pages. The main things we can add to the Open Graph tags are:
napari-hub/frontend/src/pages/collections/[symbol].tsx
Lines 84 to 102 in 36f7ce2
The text was updated successfully, but these errors were encountered: