feat: configure log retention in aws-lambda-edge-add-security-headers module #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlokshin-czi
approved these changes
Feb 15, 2023
kuannie1
approved these changes
Feb 15, 2023
michaelmcchen
deleted the
mchen/lambda-security-headers-log-retention
branch
It might have been this? I dont know if the null translates into 0 when that script reads the configuration for the log group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make this parameter configurable for a consuming TF project. Otherwise it defaults to
null, which is the equivalent of 0. A 0 day retention policy makes those logs essentially useless.Test Plan
I think somebody previously made a change in the UI to configure a 30 day retention policy on these logs. Hence, a plan (without this PR) was prompting TF to change the retention policy from 30 to 0 days.
I tested this PR out by running
make planon the consuming TF project and noting that the 30 to 0 day change is no longer prompted.References
(Optional) Additional links to provide more context.