fix: Update Snowflake Terraform provider source to Snowflake-Labs #400
Conversation
…b.com/Snowflake-Labs/terraform-provider-snowflake|g
|
I ran |
| if _, ok := matrix["module"].([]interface{}); ok { | ||
| for _, module := range matrix["module"].([]interface{}) { | ||
| modules.Add(module.(string)) | ||
| } | ||
| } else { | ||
| modules.Add(matrix["module"].(string)) |
There was a problem hiding this comment.
This is the code change I made. Let me know if this is appropriate/idiomatic for Go and/or the program itself.
There was a problem hiding this comment.
I think the infra team back then was really into code generation so I feel like this not surprising. I think the idiomatic way of doing this parsing though would be to make a type for the github action yaml and call something like err = yaml.Unmarshal(yamlFile, &config) instead of doing type casting. However, I am not sure it is worth the half an hour to do this.
There was a problem hiding this comment.
In short, I think this is fine and good 👍🏻
|
yayyy tests are passing! |
Summary
With the source of the Snowflake Terraform provider transitioned from CZI to Snowflake, hard-coded mentions need to be updated accordingly.
Also fixed code to validate CI configuration from YAML to handle string scalars as well as array for
$.jobs.test.strategy.matrix.module.Test Plan
References
ONCALL-65