Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore draft changes when computing Mean Time metrics #1051

Open
TristanCacqueray opened this issue Aug 16, 2023 · 2 comments
Open

Ignore draft changes when computing Mean Time metrics #1051

TristanCacqueray opened this issue Aug 16, 2023 · 2 comments

Comments

@TristanCacqueray
Copy link
Contributor

Should draft changes be taken into account? Perhaps a new set of metric without draft could be provided, e.g. by adding a "not status:draft" filter here:

<$> withEvents [documentType dt] (withFlavor qf firstEventOnChanges)

@TristanCacqueray
Copy link
Contributor Author

That might be more complicated because the draft status is stored in the change. So it seems like we would need a new event type to record the transition between draft created and change created (e.g. ready to be reviewed).

@morucci
Copy link
Collaborator

morucci commented Sep 19, 2023

It seems that, regarding the GitHub crawler:

could be handled to set a ready_at field. Then we could leverage that field when computing the mean time to merge metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants