Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in Offline and in slow connection, strong external js libs depend #39

Open
iBog opened this issue Feb 11, 2022 · 3 comments

Comments

@iBog
Copy link

iBog commented Feb 11, 2022

Delayed init on slow internet connection, and empty editor screen in offline mode.

@Jeferson505
Copy link

Hello, @iBog.

I forked this repository and restructured the code. One of the things I did was add offline mode support. Basically, I downloaded the JS and CSS files from the dependent libraries for the plugin.

My version of the plugin is available at the link:
https://github.com/Jeferson505/flutter_summernote

Instructions on how to use it in a flutter project are in the Setup section of README.md.

The changes I made are described in the CHANGELOG.md file, available in:
https://github.com/Jeferson505/flutter_summernote/blob/master/CHANGELOG.md

In the future, I plan to add my version of the plugin to pub.dev.

Unfortunately I couldn't support all languages ​​in offline mode. This is because to provide a language in offline mode it is necessary to add to one of the JS files (summernote.js) the content of the desired language present in the files available at:
https://github.com/Jeferson505/summernote/tree/develop/src/lang
However, to add all the plugin would be an additional 500kb. I only added the following languages ​​to offline mode:

  • en-US
  • es-ES
  • fr-FR
  • pt-BR
  • pt-PT

Feel free to use it if it suits your needs.

@meg4cyberc4t
Copy link

I wanted to express my gratitude to @Jeferson505 for the work done. Until the changes merge, I will use your fork. You guys saved my life because I was very desperate in search of a good fast html editor. <3

@Jeferson505
Copy link

Thank you very much, @meg4cyberc4t.

As there were major changes in the original architecture of the project, I chose not to do a PR. I intend to publish it pub.dev soon.

But if @chandrabezzo wishes, I can do the PR so that the changes are present in this lib as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants