Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input with whitespace or no input. issue #106 #122

Closed
wants to merge 7 commits into from
Closed

Fix input with whitespace or no input. issue #106 #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b8b1cc
simplest version of the issue #115
tzzed Jul 10, 2020
90e279e
fix dot notation, clean code more comments
Jun 2, 2020
f103790
Merge branch 'inputShell' of github.com:tzzed/genji into inputShell
tzzed Jul 10, 2020
c469d9a
Merge branch 'inputShell' of github.com:tzzed/genji into inputShell
tzzed Jul 10, 2020
a7e9cf0
Merge branch 'inputShell' of github.com:tzzed/genji into inputShell
tzzed Jul 12, 2020
61ad9e4
Merge branch 'inputShell' of github.com:tzzed/genji into inputShell
tzzed Jul 12, 2020
cac5d00
Merge branch 'inputShell' of github.com:tzzed/genji into inputShell
tzzed Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .gitignore
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions cmd/genji/shell/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ func (sh *Shell) execute(in string) {
}

func (sh *Shell) executeInput(in string) error {
in = strings.TrimSpace(in)
switch {
// if it starts with a "." it's a command
// it must not be in the middle of a multi line query though
Expand All @@ -198,6 +199,9 @@ func (sh *Shell) executeInput(in string) error {
err := sh.runQuery(sh.query)
sh.query = ""
return err
// If the input is empty
case in == "":
return nil
// If we reach this case, it means the user is in the middle of a
// multi line query. We change the prompt and set the multiLine var to true.
default:
Expand Down