Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotations to git.head subject #383

Closed
2 tasks done
migmartri opened this issue Oct 11, 2023 · 0 comments · Fixed by #402
Closed
2 tasks done

add annotations to git.head subject #383

migmartri opened this issue Oct 11, 2023 · 0 comments · Fixed by #402
Assignees

Comments

@migmartri
Copy link
Member

migmartri commented Oct 11, 2023

In #382 we added a git.head subject that contains the sha1 commit digest. It would be useful to also add additional information such as the author or the commit timestamp.

Since now in-toto subjects are resource descriptors, we could add annotations.

Note that this will require some refactoring from our end #60. This basically means

  • move from slsa.attestation struct definitions to in-toto/attestation ones.
  • Update our code to leverage resource descriptors as subject array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant