-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sinon v4 #111
Conversation
As you can see, the test suite fails on Sinon v4, so this is not mergeable. |
Yeah, I will investigate failing tests tomorrow, it was ok on local machine
…On Tue, 26 Sep 2017 at 16:52, Domenic Denicola ***@***.***> wrote:
As you can see
<https://travis-ci.org/domenic/sinon-chai/builds/279896519?utm_source=github_status&utm_medium=notification>,
the test suite fails on Sinon v4, so this is not mergeable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#111 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABur3MVOwCajJcI883nY4U7bIbRE__-wks5smQGEgaJpZM4PkAYm>
.
|
Looks like another dependency ( |
I think it's a bug in npm and it was fixed in 5.4.2: https://github.com/npm/npm/releases/tag/v5.4.2 |
steps: $ node --version
v8.5.0
$ npm --version
5.3.0
npm install
mocha — ok
npm install sinon@^3.0.0
mocha — fail
Error: Cannot find module 'nise'
Because in nise package.json there is no more `main` field |
a3537f3
to
89ab325
Compare
@domenic tests are green, so is it mergeable now ? |
@Yeti-or it could be related to sinonjs/nise#10 |
Nice hack. Can we remove lolex too then? |
89ab325
to
5368706
Compare
@domenic yes we can |
No description provided.