Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orphaned python processes on exit #2745

Merged
merged 11 commits into from
Apr 5, 2024
Merged

Fix orphaned python processes on exit #2745

merged 11 commits into from
Apr 5, 2024

Conversation

joeyballentine
Copy link
Member

No description provided.

RunDevelopment
RunDevelopment reviewed Apr 5, 2024
View reviewed changes
backend/src/server_process_helper.py Outdated Show resolved Hide resolved
backend/src/server_process_helper.py Outdated Show resolved Hide resolved
backend/src/server_process_helper.py Outdated Show resolved Hide resolved
src/main/backend/process.ts Outdated Show resolved Hide resolved
src/main/backend/process.ts Show resolved Hide resolved
src/main/gui/main-window.ts Outdated Show resolved Hide resolved
@RunDevelopment RunDevelopment mentioned this pull request Apr 5, 2024
Merged
@RunDevelopment
Use None instead of del (#2747)
bc331c1 
* Use None instead of del

* Other review

* rm test iter()
@joeyballentine joeyballentine merged commit 9d1ed55 into main Apr 5, 2024
17 checks passed
@joeyballentine joeyballentine deleted the whywontyoudie branch April 5, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyballentine @RunDevelopment