Add key information to collapsed nodes #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Is there still a spot to allow for a "locked" node icon representation in that top-line on the node? |
|
|
I'm sure we could squeeze it in somewhere |
joeyballentine
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the key information of nodes next to the title of collapsed nodes. This should make collapsed nodes more useful as the functionality of the node can be seen more easily without needing to expand it.
As for the implementation: I used the term "key info" everywhere for now, but I don't really like it. It doesn't convey that this information is only used when the node is collapsed (although maybe we'll use it somewhere also too in future? idk).