Further build fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd missed that this project is using git.mk, so .gitignore is meant to be a generated file here. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
The previous setup using $(addprefix) seems to be included in dist tarballs by the Automake used in Gitlab-CI, but not by the Automake in Debian unstable. Simplify the test setup so both work. This also results in the .test files being generated in tests/ rather than at top level, reducing clutter a bit. Signed-off-by: Simon McVittie <[email protected]>
Adding this to EXTRA_DIST inside a conditional seems to work differently for different versions of Automake. Take it out of the conditional to make it more reliable. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
This silences some warnings about duplicated variables, and also removes some unnecessary code; there's no library here, so there's certainly nothing to introspect. Signed-off-by: Simon McVittie <[email protected]>
cgwalters
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert addition of .gitignore
I'd missed that this project is using git.mk, so .gitignore is meant
to be a generated file here.
Update git.mk from its upstream
build: Add more files to be ignored by the generated .gitignore
build: Regenerate .gitignore when any Makefile changes
tests: Include test-basic.sh in dist tarballs with newer Automake
The previous setup using $(addprefix) seems to be included in dist
tarballs by the Automake used in Gitlab-CI, but not by the Automake
in Debian unstable. Simplify the test setup so both work.
This also results in the .test files being generated in tests/ rather
than at top level, reducing clutter a bit.
tests: Add tests/git-evtag-compute-py to dist tarball unconditionally
Adding this to EXTRA_DIST inside a conditional seems to work differently
for different versions of Automake. Take it out of the conditional to
make it more reliable.
build: Use subdir-objects Automake option to avoid some warnings
build: Remove GObject-Introspection machinery
This silences some warnings about duplicated variables, and also removes
some unnecessary code; there's no library here, so there's certainly
nothing to introspect.