Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobbling doesn't work on non-Bandcamp hostnames #125

Open
drguildo opened this issue Nov 23, 2016 · 4 comments
Open

Scrobbling doesn't work on non-Bandcamp hostnames #125

drguildo opened this issue Nov 23, 2016 · 4 comments

Comments

@drguildo
Copy link

If a Bandcamp page uses a non-Bandcamp hostname (e.g. http://music.musicofthemoon.com/), then scrobbling doesn't seem to work.

<meta property="fb:app_id" content="165661066782720"> seems like it might be a fairly simple and reliable way of checking for Bandcamp streaming pages.

@cgravolet
Copy link
Owner

It also means updating the permissions so scroblr initializes on every website that you visit, and last time I tried that it made a lot of users very upset.

@bonyboy
Copy link

bonyboy commented Sep 13, 2017

@cgravolet would there a way to track it from bandcamp.com so that if you did a search for something like ESPRIT 空想 that it would track the next url after you visit (or search from) the bandcamp url?

@bdukes
Copy link
Contributor

bdukes commented Sep 14, 2017

@bonyboy, no, this is about the permissions you grant the extension when you install or upgrade it. In order to have Scroblr know anything about the page on some arbitrary URL, the extension has to tell Chrome to give it access to pages on every domain, whereas right now it's restricted just to a list of music domains. Chrome's extension model doesn't let the extension get permissions to a new domain in the midst of browsing, so it doesn't help to look for something on the current page, unfortunately.

@bonyboy
Copy link

bonyboy commented Sep 14, 2017

@bdukes I see what you're saying. Thanks for taking the time to explain it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants