Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt license files + format about:license (fix #11655) #11680

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

moving-bits
Copy link
Member

@moving-bits moving-bits commented Sep 18, 2021

Description

@SammysHP
Copy link
Member

I don't think it will work this way. The license file can stay as it was, maybe just the appendix removed. But every source file requires the header.

I suggest to add the template from the appendix to the readme and at the top of the license page in the app.

@moving-bits
Copy link
Member Author

Thanks @SammysHP for reviewing. I adapted the PR accordingly:

  • removed appendix from license files
  • added info about c:geo team etc. at the beginning of about: contributors page
  • added info about c:geo team etc. in our README
  • and BTW removed the link to the old Freenode chat

@moving-bits moving-bits self-assigned this Sep 19, 2021
@bekuno
Copy link
Member

bekuno commented Sep 19, 2021

With e05ffa9 the file https://github.com/cgeo/cgeo/blob/e05ffa94276a7938e85bb5b5b5e2b1229f186770/NOTICE was created to cover the license information in c:geo. Now this will be added to the README.
Can we remove the NOTICE (I did not find where it is used in c:geo or indirect used by GitHub)? If not, then the year should renewed.

@moving-bits
Copy link
Member Author

Ok, I've updated the PR to delete the NOTICE file

@bekuno
Copy link
Member

bekuno commented Sep 19, 2021

The NOTICE file is only necessary for ASF projects, see e.g. github/choosealicense.com#701 . So it is fine to remove it.

README.md Show resolved Hide resolved
@moving-bits
Copy link
Member Author

retest this please

@moving-bits moving-bits merged commit 5d1b4b7 into cgeo:release Sep 19, 2021
@moving-bits moving-bits deleted the issue_11655 branch November 28, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants