fix: Support jumping between node.js versions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `NODE_PATH` and use bare filename for `--require` if it is needed in node.js < 12 or if node.js 12+ would otherwise require quoting the require path. This should avoid a crash when `node-preload` is setup in node.js 12 but then a test is run under node.js < 12. It should also ensure compatibility when setup is performed in node.js < 12 and tests are later run under node.js 12+. Ref istanbuljs/nyc#1246
coreyfarrell
force-pushed
the
version-jump
branch
from
8f2f130 to
638c18b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
NODE_PATHand use bare filename for--requireif it is needed innode.js < 12 or if node.js 12+ would otherwise require quoting the
require path. This should avoid a crash when
node-preloadis setup innode.js 12 but then a test is run under node.js < 12. It should also
ensure compatibility when setup is performed in node.js < 12 and tests
are later run under node.js 12+.
Ref istanbuljs/nyc#1246