Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option for preserveSymlinks. #23

Closed
coreyfarrell opened this issue Aug 18, 2019 · 1 comment
Closed

Create option for preserveSymlinks. #23

coreyfarrell opened this issue Aug 18, 2019 · 1 comment

Comments

@coreyfarrell
Copy link
Member

This should be passed on to resolve. From the resolve readme for current releases:

  • opts.preserveSymlinks - if true, doesn't resolve basedir to real path before resolving.
    This is the way Node resolves dependencies when executed with the --preserve-symlinks flag.
    Note: this property is currently true by default but it will be changed to
    false in the next major version because Node's resolution algorithm does not preserve symlinks by default.

So maybe babel-plugin-bare-import-rewrite should set preserveSymlinks: false by default and list this a breaking change. master of resolve already has preserveSymlinks: false by default but no releases have been made from master.

Requirements:

  • testing strategy to ensure the functionality is well defined and works as expected
  • determine what this does/should do in Windows or if it's a noop (specifically junctions)
@coreyfarrell
Copy link
Member Author

I've decided to keep the default for this module true but provide an option for consumers to override. I'd be open to exploring this further but for the next release I don't have time to expand testing for this.

CC @LarsDenBakker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant