Fix an issue with flagged_path and includes
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue with `flagged_path` where `includes()` would not be correctly included, and cannot be resolved using their names. The issue was simply with our passing of `is_endpoint` to the pattern class. In the case of `path()` URLs, the pattern class is `RoutePattern`, and it doesn’t double-check `is_endpoint` the way `RegexPattern` does. I have some more details in #100. This is a simple fix to change that incorrect `True` to `False`.
willbarton
commented
May 17, 2022
| @@ -127,7 +128,7 @@ def _flagged_path( | |||
| elif isinstance(view, (list, tuple)): | |||
| urlconf_module, app_name, namespace = view | |||
|
|
|||
| route_pattern = Pattern(route, name=name, is_endpoint=True) | |||
| route_pattern = Pattern(route, name=name, is_endpoint=False) | |||
There was a problem hiding this comment.
This function is a mirror of Django's _path function, which sets is_endpoint to False for include patterns (anything that match (list, tuple)). This change aligns this with Django's, and its misalignment is probably a mistake that's been here since this code was written, but probably didn't show up until Django 2.0 when path() became an option.
|
@mkeener would you be able to test if this fixes your issue? |
|
@willbarton I changed this line in my local and it works as expected, thanks! |
|
Because this is a single line change to bring our code in line with what Django already implements, and because this strikes me as a fairly major bug, I'm going to go ahead and merge this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with
flagged_pathwhereincludes()would not be correctly included, and cannot be resolved using their names.The issue was simply with our passing of
is_endpointto the pattern class. In the case ofpath()URLs, the pattern class isRoutePattern, and it doesn’t double-checkis_endpointthe wayRegexPatterndoes. I have some more details in #100.This is a simple fix to change that incorrect
TruetoFalse.This closes #100.