-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue when using scale_factor
and add_offset
in zarr
#422
Comments
Are you saying that in producing a Zarr file one has no control over the datatype of attributes? If so, this would seem to be a general, unfortunate limitation, which Zarr might want to remedy. (And I see you have raised the issue with them, so let's wait to hear what they have to say.) |
There are a number of places where the netCDF and Zarr data models don't match exactly, typed attributes is one example. The netCDF library developers have started and are working with the Zarr community on an NCZarr extension (see discussion #186) to improve the mapping between the two data models. There is also work on a Zarr version 3 specification that, as I understand it, will include some of the netCDF features that are missing in Zarr version 2. |
Agreed, this is a limitation of Zarr
Seems like the Zarr developers are aware of the issue. Thanks for pointing me there. Should the issue stay open, maybe with an "implementation" tag or similar? |
I have changed the label of this issue from |
I'm closing this issue because I believe the question was answered and there is no action for CF. Thanks for asking the question, @gdkrmr. |
Please correct me if this is not an issue:
From the CFConventions 8.1 Packed Data.
This is an issue with Zarr specifically: Attributes are defined in JSON and JSON can only define 64 bit floats.
scale_factor
andadd_offset
should be the same data type as the unpacked data. This means, at least in a strict sense, that CF-compliant Zarr cannot define 32 bit floats when usingscale_factor
and/oradd_offset
.The text was updated successfully, but these errors were encountered: