Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CeylonRunTool should not try to interpret command arguments #26

Open
quintesse opened this issue Oct 27, 2012 · 6 comments
Open

CeylonRunTool should not try to interpret command arguments #26

quintesse opened this issue Oct 27, 2012 · 6 comments
Assignees
Milestone

Comments

@quintesse
Copy link
Member

The current run tool doesn't permit the following:

ceylon run --verbose org.codejive.ceylon.httpd/1.0.2 --port 8080

That's pretty bad and I think we should fix this for M4.
(Sorry Stef ;)

@ghost ghost assigned tombentley Oct 27, 2012
@quintesse
Copy link
Member Author

I see that you can fix this by inserting -- before the module name, but I don't think that for "run" this should be necessary. But at least this means we can probably downgrade this from "high prio" and "M4".

@FroMage
Copy link
Member

FroMage commented Oct 27, 2012

Aw maaaan.....

@FroMage
Copy link
Member

FroMage commented Mar 6, 2013

M6.

@quintesse
Copy link
Member Author

This should now be fixed.... mostly.... the example uses --verbose which is exactly the only option that is hard-coded in the Launcher, at a point where we don't actually know anything about the tool we're running.

@ghost ghost assigned quintesse Sep 16, 2013
quintesse added a commit to ceylon/ceylon-common that referenced this issue Oct 2, 2013
quintesse added a commit to ceylon/ceylon-common that referenced this issue Oct 2, 2013
quintesse added a commit that referenced this issue Oct 2, 2013
…andard ceylon tool base class, so it inherits the default "verbose" option implementation (#26)
quintesse added a commit to ceylon/ceylon-js that referenced this issue Oct 2, 2013
…andard ceylon tool base class, so it inherits the default "verbose" option implementation (ceylon/ceylon-runtime#26)
@quintesse
Copy link
Member Author

I'm taking a break from this, I'm going to have to discuss with @tombentley how to proceed on this because the amount of work involved for the gain it gets us is way out of proportion.

The --verbose option is now handled at least (and generically by all our tools), what remains is --help which is what is causing the headaches.

NB: there is another hard-coded option that has to be handled so early in the startup that the tool chain can't be involved yet (a chicken and egg problem): --sysrep. Right now I see no way that a user program could use that option without resorting to the use of the -- fence argument. Hopefully there won't be much user programs that want to use the --sysrep option themselves.

@FroMage
Copy link
Member

FroMage commented Sep 25, 2014

Moving to 1.2, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants