-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for yubikey or google titan? #135
Comments
I took some time to look at this today. It appears that at some point/some setups the input form element of (name="id-challenge") returns JSON, but it does not return JSON when using a YubiKey Redacted example:
This value base64 decodes to binary which does not represent anything obvious to me. Without an understanding how to decode/translate this challenge I am unfamiliar with, it is impossible to create the needed data for the u2f function calls to sign the challenge. If anyone has any ideas? |
I am seeing this same issue but using Pixel 2 as the u2f device. So It's not just exclusive to YubiKey. |
dupe #128 |
Hi @stevemac007 , sorry to be a squeaky wheel about this; the latest version of @adcreare 's PR 136 #136 seems to work for everybody now. Are you comfortable merging this in? I'm eager to roll this out to my users but need this fix in for them first. |
Working fine for me as well. |
Merged and released as part of v0.0.32 |
I have the google titan key setup for mfa and I'm getting the following error. Any plan to support it?
ERROR:root:No JSON object could be decoded
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/aws_google_auth/init.py", line 72, in cli
process_auth(args, config)
File "/usr/lib/python2.7/site-packages/aws_google_auth/init.py", line 212, in process_auth
google_client.do_login()
File "/usr/lib/python2.7/site-packages/aws_google_auth/google.py", line 259, in do_login
sess = self.handle_sk(sess)
File "/usr/lib/python2.7/site-packages/aws_google_auth/google.py", line 364, in handle_sk
challenges = json.loads(challenges_txt)
File "/usr/lib/python2.7/json/init.py", line 339, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
The text was updated successfully, but these errors were encountered: