Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building WAR creates it twice, and in different forms #45

Open
jbrugge opened this issue May 10, 2013 · 2 comments
Open

Building WAR creates it twice, and in different forms #45

jbrugge opened this issue May 10, 2013 · 2 comments

Comments

@jbrugge
Copy link

jbrugge commented May 10, 2013

I am wanting to create a WAR for Tomcat 6, and have configured my Build.scala and plugins.sbt file according to the instructions at https://github.com/dlecan/play2-war-plugin/wiki/Configuration, based on the version of Play I am using (v2.1.0) and the target container (servlet 2.5).

When I run "mvn clean package", I am seeing a WAR built twice:

  • During the 'package' phase, when it appears to be using the play2-war SBT plugin, creating the web.xml file, and including the appropriate play2-core-servletNN*.jar.
  • During the 'package-war' phase, immediately after this, when it appears to be using a more standard Maven WAR packaging. It ignores the war/web.xml file, and includes the incorrect play2-core-servletNN*.jar file.

This second WAR is built in the same place as the first WAR, so it replaces it in the target dir.

Curiously, if I add the "false" setting to the plugin configuration, then the first (correct) WAR is still built during the 'package' phase, but the second (incorrect) WAR is suppressed during the 'package-war' phase.

I'm using the latest plugin (1.2.2) under Java 6, Maven 3.0.3.

@cmicali
Copy link

cmicali commented Sep 30, 2013

jbrugge - could you mention which setting you used to disable this?

Would be great to get a fix for this since the UlgifyJS step is so slow, it would shave 5-10 minutes off our build.

@jbrugge
Copy link
Author

jbrugge commented Sep 30, 2013

I had set the "buildWar" property to false in the plugin "configuration" element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants