-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial source code #7
Conversation
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
1816a03
to
a789f3f
Compare
Signed-off-by: Tim Ramlot <[email protected]>
a918084
to
22686bf
Compare
⚠️ Warning: This library's API is still subject to change. Developers using this library will have to update their | ||
code when updating to a newer version. | ||
|
||
0. Currently, this library is used to build production Issuers, but no open-source Issuers/ examples are available yet. We advice to use this library only for experimentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
0. Currently, this library is used to build production Issuers, but no open-source Issuers/ examples are available yet. We advice to use this library only for experimentation. | |
0. Currently, this library is used to build production Issuers, but no open-source Issuers/ examples are available yet. We advise to use this library only for experimentation. | |
1. ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just had a quick read through the code as I think we semi-agreed in the previous standups that we aren't going to do an in-depth code review as this already has been reviewed and there is too much to review for one commit.
Thank you for updating the Readme, I think it is important that we communicate clearly the production readiness. At the same time I agree that to actually make it useful more eyes on it would be good, perhaps you want to talk about how this can be used in the next dev meeting or use some other means to invite people who are willing to play around with a less stable issuer implementation.
Adding a hold in case others still want to review, but feel free to unhold when ready
/hold
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold
I think we should merge this. The idea is sound, we know how we'll test this and graduate it, we've got warnings reflecting the level of support and how alpha this is. I can't think of a good reason to delay it!
Oh, the missing OWNERS file might be the next step. I'/ll add the approved label manually for now! |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: inteon, irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The initial source code was created and battle-tested by Jetstack/ Venafi based on one of their enterprise issuers.
Jetstack/Venafi proposed to donate this source code to the cert-manager organisation.
We as cert-manager maintainers think that this project can be of great value to our community and will help us write new issuers and improve existing issuers.
The long-term goal is to use this library as a base for all external issuers and even as a base for the core issuers.
Short-term, we aim to improve this library and make developing new external issuers much easier.
See https://cert-manager.io/docs/contributing/third-party-code-donation/ for more info on the process.