Tweak golang base image + update dependent container images #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
this isn't a problem currently because we don't enable CGO, but it's safer for the build image to match Signed-off-by: Ashley Davis <[email protected]>
found using: crane ls registry.k8s.io/sig-storage/csi-node-driver-registrar crane ls registry.k8s.io/sig-storage/livenessprobe Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
baseandtags
branch
from
e456b51
to
d0cb6d4
Compare
wallrj
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
I ran make image locally and after a couple of restarts both images built successfully and I was able to push the images to a temporary registry.
make image
mkdir -p bin/tmp/{driver,approver}
tar --extract -C bin/tmp/driver -f bin/cert-manager-csi-driver-spiffe-oci
tar --extract -C bin/tmp/approver -f bin/cert-manager-csi-driver-spiffe-approver-oci
crane push ./bin/tmp/driver ${REPO_BASE}/cert-manager-csi-driver-spiffe:1httl.sh/5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe:1h
ttl.sh/5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe-approver:1h
Then briefly tested running the images locally,
$ docker run --rm ttl.sh/5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe-approver:1h
Unable to find image 'ttl.sh/5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe-approver:1h' locally
1h: Pulling from 5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe-approver
06004fb4a3b3: Pull complete
2b776ada0341: Pull complete
66d6209d01f4: Pull complete
fcb6f6d2c998: Pull complete
e8c73c638ae9: Pull complete
1e3d9b7d1452: Pull complete
4aa0ea1413d3: Pull complete
2fa82a9c76b2: Pull complete
672354a91bfa: Pull complete
4e1ae742cefc: Pull complete
Digest: sha256:6deb461705ef10ebc5fefa6580e46849832eda26d219a883c2bcc329673092e9
Status: Downloaded newer image for ttl.sh/5f102cb7-4796-4945-853b-97f54ad8fe22/cert-manager-csi-driver-spiffe-approver:1h
I1121 17:04:13.817231 1 app.go:96] "msg"="starting SPIFFE approver..." "logger"="main"
I1121 17:04:13.818230 1 server.go:50] "msg"="starting server" "addr"={"IP":"::","Port":6060,"Zone":""} "kind"="health probe" "logger"="manager"
I1121 17:04:13.818555 1 leaderelection.go:250] attempting to acquire leader lease cert-manager/spiffe.csi.cert-manager.io.../lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See slack