Change release version to use a v, fixes generation of chart #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashley Davis <[email protected]>
jetstack-bot
added
dco-signoff: yes
irbekrm
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Thanks @SgtCoDFish and sorry I should have noticed this during code review
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I should have noticed it during coding! Shit happens, thanks for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented, this will create a chart with version
0.3.0instead ofv0.3.0which will cause the Jetstack-internal charts repo to interpret the chart as invalid and in any case is a deviation from past charts where the versions were prefixed withv.This change will apply to the release in v0.3.0 since it's minor and doesn't affect running code but is required for the release.
The release won't be retagged because it doesn't seem worth it.