Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the pipelines check the code style with black #3459

Closed
psaiz opened this issue Nov 8, 2023 · 1 comment · Fixed by #3478
Closed

Ensure that the pipelines check the code style with black #3459

psaiz opened this issue Nov 8, 2023 · 1 comment · Fixed by #3478
Assignees

Comments

@psaiz
Copy link
Contributor

psaiz commented Nov 8, 2023

Similar to the inveniosoftware modules, the pipelines of opendata.cern.ch should check the code style of all the python files

@tiborsimko
Copy link
Member

Please check cernopendata-client that already has these checks, for example:

For the commit converting existing code to use black formatting, please use a neutral author such as:

$ git commit --author='CERN Open Data team <[email protected]>' -m 'global: format with black' 

For example:

We were doing this in order to respect the past authorship of the existing code, so to speak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants