React 15.5 upgrade

[Matt-Butler]

The react 15.5 release was non-passive for our packages. React is currently locked to version 15.4.2

We need to update our packages to be compatible with react 15.5.

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Limitations:

• support new prop-types package oliviertassinari/babel-plugin-transform-react-remove-prop-types#87
• react-router-redux throws warnings with react 15.5 remix-run/react-router#4932
• Support react-dom/test-utils enzymejs/enzyme#875
• support new prop-types package reactjs/react-docgen#171
• React 15.5: Support react-create-class and prop-types jsx-eslint/eslint-plugin-react#1144
• Deprecation warning with React 15.5 Hacker0x01/react-datepicker#813
• React ^15.5.0 support? formatjs/formatjs#922
• Issue with transpiled code in v2.14.0 vs v2.13.0 reactjs/react-docgen#174
• Using this in a React 15.5 application causes deprecation warnings focus-trap/focus-trap-react#12
• update(react): Migrate from the deprecated React.propTypes to prop-types package tajo/react-portal#144
• Bump version to v2.3.0 formatjs/formatjs#940

[Matt-Butler]

I started some of the 15.5.x upgrade here: https://github.com/cerner/terra-core/tree/react-15.5

• I updated each package to use the prop-types package.
• We still need to update to react 15.5 after our 3rd party issues are resolved.

[bjankord]

Looks like the enzyme PR to add compat with react 15.5 has been merged. Waiting on a release for that.

[bjankord]

Pull request for react-docgen is still open: reactjs/react-docgen#172

[Matt-Butler]

The react-docgen issue has been closed

[Matt-Butler]

react-datepicker merged their fix

[ryanthemanuel]

They released a version of react-docgen (2.14.1) to fix the build issues we were seeing around their compiling changes (reactjs/react-docgen#174). I believe that this should allow us to push to the appropriate version of react-docgen.

[bjankord]

The react-intl pr for adding react 15.5 compat has been merged. This should be our last blocker for us on adding react 15.5 compat to our components.

[Matt-Butler]

Releases to support 15.5 / 16

• babel-plugin-transform-react-remove-prop-types - https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/releases/tag/v0.4.1
• react-intl - Bump version to v2.3.0 formatjs/formatjs#940 - https://github.com/yahoo/react-intl/releases/tag/v2.3.0
• react-router - https://github.com/ReactTraining/react-router/releases/tag/v3.0.4
• react-docgen - https://github.com/reactjs/react-docgen/releases/tag/v2.15.0
• enzyme - https://github.com/airbnb/enzyme/releases/tag/v2.8.1
• react-datepicker - https://github.com/Hacker0x01/react-datepicker/releases/tag/v0.46.0
• focus-trap-react - https://github.com/davidtheclark/focus-trap-react/releases/tag/3.0.3
• react-portal - https://github.com/tajo/react-portal/releases/tag/v3.1.0

[Matt-Butler]

https://www.npmjs.com/package/react-addons-test-utils
^ This has also been deprecated.

To get our jest tests working again, we need to also install react-test-renderer. enzymejs/enzyme#875 (comment)

[Matt-Butler]

I updated the react-datepicker dependency to 0.46. In this version, they added a new prop called disableDateAutoCorrection.

[MichaelDeBoey]

react-intl v2.3.0 is released 🙂

[Matt-Butler]

After updating react-intl to 2.3.0, all of our tests now pass.

When running the site locally, I am still seeing this warning:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

I will investigate which dependency is still causing this warning.

[Matt-Butler]

After going through this exercise, I think it might be a good idea to separate out each of our components into their own webpack bundle.

• It would test the component in isolation guaranteeing that css isn't leaking from one component to another.

• It would be easier to isolate an issue down to a single component.

[Matt-Butler]

I had missed a couple proptypes. This branch is ready to upgrade to react-15.5: https://github.com/cerner/terra-core/tree/react-15.5

There are no longer warnings and all tests are passing.

[Matt-Butler]

After terra-time-input was merged into master, my tests are failing again. This is the issue:

• Console warning "Failed prop type: React.PropTypes type checking code is stripped in production." when using react-text-mask text-mask/text-mask#510

I can't merge the pull request until that issue is resolved.

^ We have removed text-mask for now. Closing this issue.