Tenant dropdown not working without creating new datasource variable

[geekdave]

First off, big thanks to @dmyerscough for implementing the dynamic tenant query as a dashboard variable!

I'm not sure if I am missing a step, but after this change the dashboards no longer worked out of the box and required some tweaking. On all 3 dashboards I got this error in the Tenant dropdown:

Datasource ${datasource} was not found

Looks like the template variable for the tenant is expecting another ${datasource} variable here:

        "datasource": {
          "type": "prometheus",
          "uid": "${datasource}"
        },
        "definition": "label_values(cortex_distributor_requests_in_total,user)",
        "description": "Tenants for mimir",

I tried adding my own Prometheus datasource variable to each dashboard like so:

...and that fixed the issue! 🎉

But before I submit a PR with this datasource included in each dashboard, I wanted to check if there was something obvious I was missing that would have allowed these dashboards to work without that change?

[dmyerscough]

@geekdave I didn't get this error when importing the dashboard, let me try again this weekend and Ill let you know if I hit this error. The change I made grabs the tenants from Prometheus metrics, Ill check to see if I get the error you're getting.

[samui-aug]

I get the same error as @geekdave but fetch datasource name from prometheus won't help me because my datasource name not align with my tenant id setup

fixed it by selecting correct datasource with the same query get me a list of tenant now

[dmyerscough]

I tested this yesterday, I didn't get asked to select a datasource for Prometheus so that will likely need to be patch. I only get asked to select the json backend for the canary analysis datasource.

[samui-aug]

This is what happen when I access the Settings -> Variables the first time from imported dashboard