Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i-records-files: checks & updates #2779

Open
3 tasks done
pamfilos opened this issue Apr 4, 2023 · 4 comments
Open
3 tasks done

i-records-files: checks & updates #2779

pamfilos opened this issue Apr 4, 2023 · 4 comments
Assignees

Comments

@pamfilos
Copy link
Collaborator

pamfilos commented Apr 4, 2023

  • we need to upgrade to the commit that intializes views entry-points inveniosoftware/invenio-records-files@27a5f5c
  • (v1.1.0) investigate behaviour of record class that creates bucket. Same behavior as before? Does it conflict with our bucket creation?
  • try to upgrade to v1.2.0
@ParthS007 ParthS007 self-assigned this Apr 24, 2023
@ParthS007
Copy link
Contributor

@ParthS007
Copy link
Contributor

ParthS007 commented Apr 25, 2023

  • Addition of _bucket in record metadata.
  • Change in bucket creation.
  1. Tested with previous forked version and new one with i-r-files==1.2.1
  2. The behavior of bucket creation is same as before and we are overriding the bucket creation so it stays the same. There is no conflict in bucket creation(means only 1 bucket is created and files are associated with that bucket only).

@ParthS007
Copy link
Contributor

  • Added methods for overriding methods coming from i-r-files in Records module api.

@ParthS007
Copy link
Contributor

  • Fixed the get_record method in CAPDeposit to check if files exist before dumps().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants