Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deposits: update 'permissions' action method to better handle exception #2023

Open
pamfilos opened this issue Jan 4, 2021 · 0 comments · May be fixed by #2027
Open

deposits: update 'permissions' action method to better handle exception #2023

pamfilos opened this issue Jan 4, 2021 · 0 comments · May be fixed by #2027
Assignees
@Lilykos @pamfilos
Labels
Type: bug

Comments

@pamfilos
Copy link
Collaborator

pamfilos commented Jan 4, 2021

Bug report

What is the current behavior?

Currently, it is possible to encounter issues when adding/removing a deposit permission (e.g when permissions are not synced between DB and ES, the operation will fail

If the current behavior is a bug, please provide the steps to reproduce.

Better, error handling and reassuring that operation will always go through
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Jan 11, 2021
@Lilykos
deposits: update 'permissions' action method to better handle exception
bf2964b 
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
@Lilykos Lilykos linked a pull request Jan 11, 2021 that will close this issue
Open
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Feb 1, 2021
@Lilykos
deposits: update 'permissions' action method to better handle exception
c94d4de 
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Feb 15, 2021
@Lilykos
deposits: update 'permissions' action methods
653f584 
* refactors the code so that when an action is not possible,
  it fails silently, and the flow doesn't stop
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Feb 23, 2021
@Lilykos
deposits: update 'permissions' action methods
db527f9 
* refactors the code so that when an action is not possible,
  it fails silently, and the flow doesn't stop
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue Mar 10, 2021
@Lilykos
deposits: update 'permissions' action methods
3ef338e 
* refactors the code so that when an action is not possible,
  it fails silently, and the flow doesn't stop
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
Lilykos added a commit to Lilykos/analysispreservation.cern.ch that referenced this issue May 31, 2021
@Lilykos
deposits: update 'permissions' action methods
22197a7 
* refactors the code so that when an action is not possible,
  it fails silently, and the flow doesn't stop
* closes cernanalysispreservation#2023

Signed-off-by: Ilias Koutsakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilykos Lilykos

@pamfilos pamfilos

Labels
Type: bug
Projects
None yet
Milestone
No milestone
2 participants
@Lilykos @pamfilos