-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop shadow and background blur #81
Comments
Blur is probably an overkill, but definitely a +1 from me for a shadow. Personally I don't struggle with it that much because my composition manager that I use in Linux fades everything in background when Cerebro opens, it has effect similar to the blur, but not as drastic. |
@AlexAlabyev @maximbaz AFAIK electron supports window show on macOS:
But as I see shadow is possible: we can do a theme with transparent window, and just add css Current I didn't implement good API for external themes, but we started conversation in #66. So, I'm thinking about providing API for external themes, so developers can control:
|
@maximbaz I agree, blur is very subjective and not everyone likes it. It would be nice to have it as an option in settings, maybe. @KELiON external themes would be nice, do you think we could add a basic default theme with a good looking |
Just a fair warning, you might get a push-back from Linux users. Some people are used to control how their window looks via composition managers, so that the styles are identical for all apps. For example, I enabled background fading and shadows, and it looks like this: Right now I can control shadow radius, colors, offset - and it affects all apps on my box in the same way. Personally, I don't mind if you implement a shade, but I want you to be aware of this :) |
@maximbaz right, thanks, that's a fair concern. It's basically just a problem with Windows then. |
@KELiON and @maximbaz I've created the
or it's more difficult then that and will not appear in the next build? Link to jsfiddle
|
I've just played with this a bit, but I couldn't achieve transparency for the main window. Not sure if this is a lack of support for Linux or I'm just doing something wrong. Tried to google it a bit, found an old pull request for electron that implements transparency... for MacOS only. Not sure if something changed since then. If there is no support for Linux / Windows, this could be the reason why native property |
@maximbaz have you tried adding
According to this documentation, there are some limitations, for example to be able to click through the transparent area you should add It also says that for linux you should type If it doesn't help, I can create a thread on stackoverflow and ask other developers for a better solution, maybe there are other ways to do this. |
Tried now, the How does it look for you on Windows? Do you have the dev environment configured, to try?
I'll also watch #66 to see if attempts to implement transparency appear, and how it will work on different OS. |
@maximbaz at the moment I don't have the dev environment configured. I just added those parameters to files. Is there a quick way to run it and see if it works? |
You can play with CSS (type |
Has anyone achieved the transparent background and rounded edges for Linux? I tried to play with the Development Mode and change the CSS but I couldn't get the transparent background (and therefore you can't see the rounded edges, only if you add a border with a different color). Please someone that know more Electron+CSS do something like #66 for Linux :D |
@cncastillo to do so you'll need to use not only CSS, but change some |
I will close because this issue is very old and has already been fixed |
Drop shadow
Is it possible to add a bigger and darker drop shadow for cerebro? Default shadows are almost invisible and it's hard to distinguish cerebro search bar from other windows
Background blur
Have you considered a background blur? It helps to focus on the search bar even more, and it also looks cool, especially with a smooth linear transition (not an instant blur like on the screenshot)
Not everyone would want it, though. In my opinion, it should be as an option in settings. Maybe even add another option to change the amount of blur
(gif has only 256 colors, so it looks worse than in reality)
The text was updated successfully, but these errors were encountered: