Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master is currently broken #423

Closed
Stanzilla opened this issue Dec 2, 2017 · 9 comments
Closed

master is currently broken #423

Stanzilla opened this issue Dec 2, 2017 · 9 comments

Comments

@Stanzilla
Copy link
Contributor

Errors with
cerebro_2017-12-02_20-11-23

on start

@lawgsy
Copy link
Contributor

lawgsy commented Dec 2, 2017

I can compile and run it fine, can you give us more information about your environment? Did you install using a recent version of yarn?
What command do you use to try and launch the application?

@Stanzilla
Copy link
Contributor Author

Stanzilla commented Dec 2, 2017

that was with yarn 1.3.2 and yarn && yarn run release on Windows, Are you on Windows?

@lawgsy
Copy link
Contributor

lawgsy commented Dec 3, 2017

Yes I am currently on Windows. I'm surprised you got that far into running yarn run release (I am getting an error about being unable to compile for macOS from a Windows computer, because the release script of package.json contains the flag -wml, which includes m for mac).

Can you try the following from your cerebro\ directory?

  1. yarn && cd app && yarn && cd ../ to install all dependencies (and return working directory to cerebro\)
  2. yarn run package to build and package (required for the first time to generate CSS in the right directories when running without packaging later)
  3. yarn run start to run in production or yarn run dev to run in development setting

After step 2 succeeds, you should also find a binary in cerebro\release\win-unpacked (which will obviously not be updated after editing the source until you run package again, whereas start/dev should reflect changes - dev often even without restarting)

@Stanzilla
Copy link
Contributor Author

I think I already found the problem, Duplicate of #426 I guess

@KELiON
Copy link
Collaborator

KELiON commented Dec 6, 2017

@Stanzilla nope, #426 is another issue:) This one was fixed here

@Stanzilla
Copy link
Contributor Author

Stanzilla commented Dec 6, 2017

oh durr! thanks! It now fails with

λ yarn && cd app && yarn && cd ../
yarn install v1.3.2
[1/4] Resolving packages...
success Already up-to-date.
$ concurrently "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"
[0] node node_modules/fbjs-scripts/node/check-dev-engines.js package.json exited with code 0
Done in 1.17s.
yarn install v1.3.2
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[1/2] ⢀ ref: ..\src\binding.cc(620): note: No user-defined-conversion operator available that can
[-/2] ⢀ waiting...
[-/2] ⢀ waiting...
[-/2] ⢀ waiting...
error C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref
Output:
C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )
else (node "" rebuild )
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | win32 | x64
gyp info spawn C:\Python27\python.exe
gyp info spawn args [ 'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-G',
gyp info spawn args   'msvs_version=2015',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\Benjamin\\VCS\\Git\\cerebro\\app\\node_modules\\ref\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\addon.gypi', gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\Benjamin\\.node-gyp\\9.2.0\\include\\node\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\Benjamin\\.node-gyp\\9.2.0',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\Users\\Benjamin\\.node-gyp\\9.2.0\\<(target_arch)\\node.lib',
gyp info spawn args   '-Dmodule_root_dir=C:\\Users\\Benjamin\\VCS\\Git\\cerebro\\app\\node_modules\\ref', gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\Users\\Benjamin\\VCS\\Git\\cerebro\\app\\node_modules\\ref\\build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn msbuild
gyp info spawn args [ 'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64' ]
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  binding.cc
  win_delay_load_hook.cc
c:\users\benjamin\vcs\git\cerebro\app\node_modules\nan\nan_maybe_43_inl.h(112): warning C4996: 'v8::Object::ForceSet': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref\build\binding.vcxproj]
  c:\users\benjamin\.node-gyp\9.2.0\include\node\v8.h(3114): note: see declaration of 'v8::Object::ForceSet' (compiling source file ..\src\binding.cc)
..\src\binding.cc(619): error C2664: 'v8::Maybe<bool> v8::Object::ForceSet(v8::Local<v8::Context>,v8::Local<v8::Value>,v8::Local<v8::Value>,v8::PropertyAttribute)': cannot convert argument 3 from 'v8::PropertyAttribute' to 'v8::Local<v8::Value>' [C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref\build\binding.vcxproj]
  ..\src\binding.cc(619): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
..\src\binding.cc(620): error C2664: 'v8::Maybe<bool> v8::Object::ForceSet(v8::Local<v8::Context>,v8::Local<v8::Value>,v8::Local<v8::Value>,v8::PropertyAttribute)': cannot convert argument 3 from 'v8::PropertyAttribute' to 'v8::Local<v8::Value>' [C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref\build\binding.vcxproj]
  ..\src\binding.cc(620): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
gyp ERR! build error
gyp ERR! stack Error: `msbuild` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:159:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
gyp ERR! System Windows_NT 10.0.16299
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Benjamin\VCS\Git\cerebro\app\node_modules\ref

@Stanzilla Stanzilla reopened this Dec 6, 2017
@lawgsy
Copy link
Contributor

lawgsy commented Dec 6, 2017

Cannot reproduce new issue. It appears the current binaries currently produce the error you mentioned at the start of this issue though.

@KELiON
Copy link
Collaborator

KELiON commented Dec 20, 2017

@Stanzilla what version of node did you use, when you had second issue? Probably it is somehow related to #426

@ldexterldesign
Copy link

+1

screen shot 2018-06-02 at 16 53 09

Let me know if you have any issues - happy to help

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants