New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refferal url parsing #84

Open

Guria opened this issue Mar 4, 2016 · 1 comment

Collaborator

Guria commented Mar 4, 2016 •

edited

Loading

Problem: count referrer and clean shown url
Solutions:

As in legacy urls support case docs: legacy routes support #72 referral links first hits the server, so consider to count referrer on server side and redirect client to clean url
If you have to count referrer on client, you can clean url before router will trigger:

controller.on('modulesLoaded', function () {
  controller.getSignals().refLinkNavigated({ ref: getRef(location.href) }, { immediate: true })
  history.replaceState({}, '', cleanUrl(location.href))
})

jeroenverfallie mentioned this issue

Implement a fallback method when parsing goes wrong #98

Closed

Collaborator

christianalfoni commented Jan 23, 2017

This seems like an edge case? Do not have enough insight to make any decision or more comments :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment