Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow primitive types as the initial signal input #4

Open
saulshanabrook opened this issue Jul 2, 2016 · 4 comments
Open

Don't allow primitive types as the initial signal input #4

saulshanabrook opened this issue Jul 2, 2016 · 4 comments

Comments

@saulshanabrook
Copy link

In cerebral, we only want to allow signals to be called with objects, not primitive types (cerebral/cerebral#252). If we wanted action tree to handle this for us, it should require an object as the initialPayload (and probably the subsequent payload). This is related to #2.

@Guria If this shouldn't be handled with action-tree can you reopen cerebral/cerebral#252 ?

@Guria
Copy link
Contributor

Guria commented Jul 21, 2016

@christianalfoni what your opinion here? should we allow only serializable objects in action-tree or keep it unopinionated about it?

@Guria
Copy link
Contributor

Guria commented Jul 21, 2016

Oh. I think we can restrict to Object, no matter if it serializable or not in action-tree and keep checking in cerbral dev-mode that payload is serializable

@saulshanabrook
Copy link
Author

I opened this one just to make sure the type is Object, not touching on serializability.

@Guria
Copy link
Contributor

Guria commented Jul 22, 2016

Yeah. We should check it here, because we can't merge primitives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants