Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support effectiveGasPrice on dynamicFee receipts #79

Closed
i-norden opened this issue Jul 9, 2021 · 1 comment
Closed

Support effectiveGasPrice on dynamicFee receipts #79

i-norden opened this issue Jul 9, 2021 · 1 comment
Assignees
@i-norden

Comments

@i-norden
Copy link
Collaborator

i-norden commented Jul 9, 2021

ethereum/execution-specs#206
@i-norden i-norden changed the title Support effectiveGasPrice on dynamicFeeTx Receipts Support effectiveGasPrice on dynamicFee receipts Jul 9, 2021
@arijitAD arijitAD mentioned this issue Sep 9, 2021
Closed
@i-norden
Copy link
Collaborator Author

@dboreham @AFDudley pinging since this issue has been buried but is still needed to perfectly replicate the geth eth json rpc api.

We need to add https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1651 to

ipld-eth-server/pkg/eth/api.go

Line 499 in 8c55b63

func (pea *PublicEthAPI) localGetTransactionReceipt(ctx context.Context, hash common.Hash) (map[string]interface{}, error) {

@i-norden i-norden mentioned this issue Apr 1, 2023
Merged
@i-norden i-norden self-assigned this Apr 1, 2023
@i-norden i-norden closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i-norden i-norden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Support effectiveGasPrice on dynamicFee receipts cerc-io/ipld-eth-server
1 participant
@i-norden