Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea broke CI/Actions for mirrored repos #40

Closed
dboreham opened this issue May 25, 2023 · 7 comments
Closed

Gitea broke CI/Actions for mirrored repos #40

dboreham opened this issue May 25, 2023 · 7 comments

Comments

@dboreham
Copy link
Collaborator

This happened between 1.19.1 and 1.19.2 I suspect and broke our gitea-hosted CI jobs.

Previously jobs would be run on "push" events when commits were synced over from the origin Github repo.
Then, when the Gitea update was deployed, those jobs never ran again.

@dboreham
Copy link
Collaborator Author

Some debugging reveals the problem to be related to changes made in the naming of the "ref" on a push event.
When the push originates locally it has the form "refs/heads/" however when it originates in a synced push the ref string is just the branch name (e.g. "main"). Gitea's matching code now fails to match the job branch spec (e.g. "main") with what it expects ("refs/heads/main") and so does not run the job.

@dboreham
Copy link
Collaborator Author

dboreham commented May 25, 2023

Tested a possible fix and reported the bug in the gitea project: go-gitea/gitea#24926
There was an existing bug open: go-gitea/gitea#24824

@dboreham
Copy link
Collaborator Author

This issue is fixed with merge of this PR today: go-gitea/gitea#24634
Once we deploy a release with the fix, we can close this issue.

@dboreham
Copy link
Collaborator Author

Fix was backported to the 1.19 branch: go-gitea/gitea#23070 and the docker image 1.19-nightly was built 30min later, so I assume has the fix. I will test that image with a view to deploying it in production.

@dboreham
Copy link
Collaborator Author

The backported fix does not seem to work.

@dboreham
Copy link
Collaborator Author

Fixed in the 1.19 branch with go-gitea/gitea#24994 so we can deploy the 1.19-nightly image, or any subsequent 1.19 point release.

@dboreham
Copy link
Collaborator Author

dboreham commented Jun 6, 2023

Resolved now that the 1.19 nightly image has been deployed.

@dboreham dboreham closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant