Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use akka-stream_3 for Scala 3 #1

Open
emmett-rayes opened this issue Sep 5, 2024 · 3 comments
Open

Use akka-stream_3 for Scala 3 #1

emmett-rayes opened this issue Sep 5, 2024 · 3 comments

Comments

@emmett-rayes
Copy link

Currently, there is an explicit dependency on "com.typesafe.akka:akka-stream_2.13:2.6.20" for Scala 3 in build.sbt. This dependency transitively includes the 2.13 Versions of the following dependencies as well:

  • com.typesafe.akka:akka-protobuf-v3
  • com.typesafe.akka:akka-actor
  • com.typesafe.akka:akka-stream
  • org.scala-lang.modules:scala-java8-compat

This makes it impossible to use ws-client or any of its dependents like openai-scala-client in projects where one of mentioned transitive dependencies is used in the Scala 3 Version, e.g. akka-stream.

Is there a reason why ws-client can't upgrade to newer versions of akka-stream with Scala 3 support?

@peterbanda
Copy link
Member

Hey @emmett-rayes , when the dependencies were set, 2.10.0-RC6 was the latest version compatible with Scala 3.2. I think it can be upgraded now

@emmett-rayes
Copy link
Author

Hi @peterbanda, good to know! I created a PR that fixes this issue #2

@peterbanda
Copy link
Member

Ok looks good! Thanx for taking care of it. The only question is whether the akka-stream version you set is compatible with play-ahc-ws-standalone and play-ws-standalone-json libs (and with akka-http used for streaming)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants