Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ENTER" rather than "Enter" in check for keyup value in tutorial example on README.md #407

Closed
mdmeacham opened this issue Aug 24, 2024 · 1 comment

Comments

@mdmeacham
Copy link

Describe the bug
On README.md on https://github.com/centrifugal/centrifuge, the example index.html has a check for which key is used in the input element.

The current javascript has if (e.key === "ENTER") with uppercase ENTER

Should be if (e.key === "Enter")

Causes example index.html to not react to user input

To Reproduce
Steps to reproduce the behavior:

  1. Follow tutorial and see that user input in browser does not send message

Expected behavior
Pressing enter on input element causes message to be sent

@FZambia
Copy link
Member

FZambia commented Aug 25, 2024

Hello @mdmeacham

Many thanks for the report - just fixed. I guess there were some people who stopped looking at the library after the readme example failure 🫤

@FZambia FZambia closed this as completed Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants