Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when trying to authenticate private channels #76

Closed
xAockd opened this issue Feb 4, 2019 · 4 comments
Closed

Race condition when trying to authenticate private channels #76

xAockd opened this issue Feb 4, 2019 · 4 comments

Comments

@xAockd
Copy link

xAockd commented Feb 4, 2019

Step to reproduce:

  1. simulate long running subscription response on app backend
  2. restart centrifugo while the subscription is running

Response:
error in reply client=aaa32115-f0e6-4049-84f7-92f2a75ac4c3 command="id:55 method:SUBSCRIBE params:"{"channel":"$privte.channel","token":"token"}" " error="103: permission denied" reply="id:55 error:<code:103 message:"permission denied" > " user=3389

Additional technical details:
If long-running subscription only for the first request we receive another error

error in reply client=aaa32115-f0e6-4049-84f7-92f2a75ac4c3 command="id:55 method:SUBSCRIBE params:"{"channel":"$privte.channel","token":"token"}" " error="105: "already subscribed" reply="id:55 error:<code:105 message:"already subscribed" > " user=3389

@xAockd
Copy link
Author

xAockd commented Feb 4, 2019

It fixed for me the issue.
Probably it's not the best option. But as a hotfix...
#77

@FZambia
Copy link
Member

FZambia commented Feb 6, 2019

Will try to make release later today

@xAockd
Copy link
Author

xAockd commented Feb 6, 2019

Thanks. Really waiting for the fix.

@FZambia
Copy link
Member

FZambia commented Feb 6, 2019

just released 2.1.2, please check it out

@FZambia FZambia closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants