Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to not set withCredentials to true #155

Closed
yakimka opened this issue Jul 27, 2021 · 2 comments · Fixed by #156
Closed

Ability to not set withCredentials to true #155

yakimka opened this issue Jul 27, 2021 · 2 comments · Fixed by #156

Comments

@yakimka
Copy link
Contributor

yakimka commented Jul 27, 2021

I have the same problem that in #110 and I don't want to set withCredentials to true. I believe that this should be configured in the configuration parameters.

If you disable withCredentials you won't get cookies with request. Do you have an alternative way to decide whether user is allowed to subscribe on private channel or not?

I can set Authorization header with token (example)
@FZambia
Copy link
Member

FZambia commented Jul 27, 2021

@yakimka hello!

Could you send a pr with option disableWithCredentials (by default false - i.e. withCredentials is used)?

@yakimka
Copy link
Contributor Author

yakimka commented Jul 28, 2021 •
edited
Loading

Hello! #156

@yakimka yakimka mentioned this issue Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add disableWithCredentials option. Resolves #155
2 participants
@FZambia @yakimka